Show error when attempting to create bcachefs subvolume in place of dir#1238
Draft
zebreus wants to merge 1 commit intonix-community:masterfrom
Draft
Show error when attempting to create bcachefs subvolume in place of dir#1238zebreus wants to merge 1 commit intonix-community:masterfrom
zebreus wants to merge 1 commit intonix-community:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts bcachefs subvolume creation behavior so that disko no longer silently skips creating a subvolume when a directory already exists at the target path, instead letting bcachefs subvolume create surface the error.
Changes:
- Removed the “is it a directory?” guard when probing whether a target path is already a subvolume.
- Always attempts
bcachefs subvolume createafter ensuring the parent directory exists, allowing bcachefs-tools to error out when appropriate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bcachefs module currently silently skips subvolume creation if there is already a directory present at the given path. As far as I can tell disko most likely never hits that condition, but if it does should most likely fail/print the error. The bcachefs tools already fail and print an error when attempting to create a subvolume in a place where there is already a directory, so the additional check in disko can just be removed.